Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more comment for missing alert channels #934

Conversation

Antoine-C
Copy link
Contributor

@Antoine-C Antoine-C commented Jan 30, 2024

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  • Add a better explanation in case the alert subscription array is empty or missing.

Copy link

@Antoine-C Antoine-C marked this pull request as ready for review January 30, 2024 09:26
@Antoine-C Antoine-C enabled auto-merge (squash) January 30, 2024 09:29
@Antoine-C Antoine-C merged commit cac4d31 into main Jan 30, 2024
3 checks passed
@Antoine-C Antoine-C deleted the antoinecoutellier/sc-16858/add-warning-to-cli-tf-when-pushing-checks branch January 30, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants